Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error page for advance authorization errors #1123

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Update error page for advance authorization errors #1123

merged 2 commits into from
Jun 6, 2024

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Jun 4, 2024 •
edited
Loading

What does this PR do?

This PR enhances the error page to display advance authorization error messages propagated as response data.

Screencast

https://youtu.be/1BJ5CPf07pw
Error Page for Advance Authorization error

What issues does this PR fix or reference?

resolves eclipse-che/che#22912

Is it tested? How?

  1. Deploy Eclipse Che and patch CR with this command: 
    kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1123", name: che-dashboard}]}}]"
  2. Update the CR to enable advanced authorization and add your user to the denyUsers list: 
    spec:
  ...
  networking:
    auth:
      advancedAuthorization:
        denyUsers:
          - <your-user-name>
  3. Wait for the che-server pod to restart and then refresh the Dashboard page.
  4. You should be able to see the error page with the reason for the error.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Jun 4, 2024

Click here to review and test in web IDE: Contribute

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1123

kubectl patch command 
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1123", name: che-dashboard}]}}]"

@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.75%. Comparing base (9873276) to head (bbdf160).
Report is 6 commits behind head on main.

Files Patch % Lines
...-frontend/src/Layout/ErrorReporter/Issue/index.tsx 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
+ Coverage   89.60%   89.75%   +0.14%     
==========================================
  Files         408      411       +3     
  Lines       41604    41932     +328     
  Branches     2786     2826      +40     
==========================================
+ Hits        37281    37634     +353     
+ Misses       4297     4274      -23     
+ Partials       26       24       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1123

kubectl patch command 
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1123", name: che-dashboard}]}}]"

@akurinnoy akurinnoy marked this pull request as ready for review June 5, 2024 12:47
@akurinnoy akurinnoy requested review from olexii4 and ibuziuk as code owners June 5, 2024 12:47
olexii4
olexii4 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Знімок екрана 2024-06-05 о 17 13 34

LGTM

@openshift-ci openshift-ci bot added the lgtm label Jun 5, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk ibuziuk merged commit 3d062e1 into main Jun 6, 2024
18 checks passed
@ibuziuk ibuziuk deleted the update-error-page branch June 6, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olexii4 olexii4 olexii4 approved these changes

@ibuziuk ibuziuk ibuziuk approved these changes

Assignees

@ibuziuk ibuziuk

@olexii4 olexii4

Labels
lgtm
Projects
None yet
Milestone
No milestone
4 participants
@akurinnoy @che-bot @ibuziuk @olexii4